From 2e7e6e6ee1da6d1e37f80df4bb7a27dbb486271f Mon Sep 17 00:00:00 2001 From: rmp Date: Tue, 8 Jan 2013 23:40:09 +0100 Subject: [PATCH 1/3] Disable automatic mailing to the group. Most comments are not so essential for the whole team and plenty are private notes. It's recommended to disable those and enable by hand when a comment is important. --- app/views/notes/_common_form.html.haml | 4 ++-- app/views/notes/_per_line_form.html.haml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/notes/_common_form.html.haml b/app/views/notes/_common_form.html.haml index d76be75bc27..236742d105e 100644 --- a/app/views/notes/_common_form.html.haml +++ b/app/views/notes/_common_form.html.haml @@ -22,12 +22,12 @@ .span4.notify_opts %h6.left Notify via email: = label_tag :notify do - = check_box_tag :notify, 1, @note.noteable_type != "Commit" + = check_box_tag :notify, 0, @note.noteable_type != "Commit" %span Project team - if @note.notify_only_author?(current_user) = label_tag :notify_author do - = check_box_tag :notify_author, 1 , @note.noteable_type == "Commit" + = check_box_tag :notify_author, 0 , @note.noteable_type == "Commit" %span Commit author .span5.attachments %h6.left Attachment: diff --git a/app/views/notes/_per_line_form.html.haml b/app/views/notes/_per_line_form.html.haml index ff80ad4e0d5..7b19c6dc83e 100644 --- a/app/views/notes/_per_line_form.html.haml +++ b/app/views/notes/_per_line_form.html.haml @@ -23,12 +23,12 @@ %h6.left Notify via email: .labels = label_tag :notify do - = check_box_tag :notify, 1, @note.noteable_type != "Commit" + = check_box_tag :notify, 0, @note.noteable_type != "Commit" %span Project team - if @note.notify_only_author?(current_user) = label_tag :notify_author do - = check_box_tag :notify_author, 1 , @note.noteable_type == "Commit" + = check_box_tag :notify_author, 0 , @note.noteable_type == "Commit" %span Commit author :javascript -- GitLab From 3cccbf8a4378963caf5b7bd49bf971b7ca87bd87 Mon Sep 17 00:00:00 2001 From: rmp Date: Tue, 8 Jan 2013 23:42:09 +0100 Subject: [PATCH 2/3] Possibility to open a new issue form after viewing another one. While looking at an issue you no longer need to go back to the issue list for creating the next one. --- app/views/issues/show.html.haml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/views/issues/show.html.haml b/app/views/issues/show.html.haml index 1d4d6a13c2b..7996c317548 100644 --- a/app/views/issues/show.html.haml +++ b/app/views/issues/show.html.haml @@ -6,6 +6,10 @@ = @issue.created_at.stamp("Aug 21, 2011") %span.right + - if can? current_user, :write_issue, @project + = link_to new_project_issue_path(@project, issue: { assignee_id: params[:assignee_id], milestone_id: params[:milestone_id]}), class: "btn grouped" do + %i.icon-plus + New Issue - if can?(current_user, :admin_project, @project) || @issue.author == current_user - if @issue.closed = link_to 'Reopen', project_issue_path(@project, @issue, issue: {closed: false }, status_only: true), method: :put, class: "btn grouped reopen_issue" -- GitLab From 1abc70fbf67fd1c23f8a79b2b56102af397c2519 Mon Sep 17 00:00:00 2001 From: rmp Date: Wed, 9 Jan 2013 16:44:00 +0100 Subject: [PATCH 3/3] Comment wont be mailed to team by default. No more magic for deciding which comment is important or not. --- app/views/notes/_common_form.html.haml | 4 ++-- app/views/notes/_per_line_form.html.haml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/notes/_common_form.html.haml b/app/views/notes/_common_form.html.haml index 236742d105e..ae5d7250421 100644 --- a/app/views/notes/_common_form.html.haml +++ b/app/views/notes/_common_form.html.haml @@ -22,12 +22,12 @@ .span4.notify_opts %h6.left Notify via email: = label_tag :notify do - = check_box_tag :notify, 0, @note.noteable_type != "Commit" + = check_box_tag :notify, 1, false %span Project team - if @note.notify_only_author?(current_user) = label_tag :notify_author do - = check_box_tag :notify_author, 0 , @note.noteable_type == "Commit" + = check_box_tag :notify_author, 1 , false %span Commit author .span5.attachments %h6.left Attachment: diff --git a/app/views/notes/_per_line_form.html.haml b/app/views/notes/_per_line_form.html.haml index 7b19c6dc83e..ce391dccae7 100644 --- a/app/views/notes/_per_line_form.html.haml +++ b/app/views/notes/_per_line_form.html.haml @@ -23,12 +23,12 @@ %h6.left Notify via email: .labels = label_tag :notify do - = check_box_tag :notify, 0, @note.noteable_type != "Commit" + = check_box_tag :notify, 1, false %span Project team - if @note.notify_only_author?(current_user) = label_tag :notify_author do - = check_box_tag :notify_author, 0 , @note.noteable_type == "Commit" + = check_box_tag :notify_author, 1 , false %span Commit author :javascript -- GitLab