bundle exec rake gitlab:check RAILS_ENV=production fails on OS X for GitLab Shell version

Created by: andreaskasa

hoth:gitlab git$ bundle exec rake gitlab:env:info RAILS_ENV=production

System information System: Mac OS X 10.6.8 Current User: git Using RVM: no Ruby Version: 1.9.3p392 Gem Version: 1.8.23 Bundler Version:1.3.5 Rake Version: 10.0.4

GitLab information Version: 5.1.0 Revision: 0c4507bf Directory: /Volumes/Daten/Hoth/git/gitlab DB Adapter: mysql2 URL: http://xyz.xyz.xyz HTTP Clone URL: http://xyz.xyz.de/some-project.git SSH Clone URL: git@xyz.xyz.xyz:some-project.git Using LDAP: no Using Omniauth: no

GitLab Shell Version: 1.3.0 Repositories: /Volumes/Daten/Hoth/git/repositories Hooks: /Volumes/Daten/Hoth/git/gitlab-shell/hooks Git: /opt/local/bin/git

hoth:gitlab git$ bundle exec rake gitlab:check RAILS_ENV=production Checking Environment ...

Git configured for git user? ... yes Has python2? ... yes python2 is supported version? ... yes

Checking Environment ... Finished

Checking Gitlab Shell ...

GitLab Shell version? ... unknown rake aborted! undefined method strip' for nil:NilClass /Volumes/Daten/Hoth/git/gitlab/lib/tasks/gitlab/check.rake:663:incheck_gitlab_shell' /Volumes/Daten/Hoth/git/gitlab/lib/tasks/gitlab/check.rake:369:in `block (3 levels) in <top (required)>' Tasks: TOP => gitlab:check => gitlab:gitlab_shell:check (See full trace by running task with --trace)

when i copy the lines for gitlab_shell_version from lib/tasks/gitlab/info.rake to lib/tasks/gitlab/check.rake row 559

  gitlab_shell_version_file = "#{Gitlab.config.gitlab_shell.repos_path}/../gitlab-shell/VERSION"
  if File.readable?(gitlab_shell_version_file)
    gitlab_shell_version = File.read(gitlab_shell_version_file)
  end

to replace

  gitlab_shell_version_file = "#{gitlab_shell_user_home}/gitlab-shell/VERSION"
  if File.readable?(gitlab_shell_version_file)
    File.read(gitlab_shell_version_file)
  end

the checks are ok

hoth:gitlab git$ bundle exec rake gitlab:check RAILS_ENV=production Checking Environment ...

Git configured for git user? ... yes Has python2? ... yes python2 is supported version? ... yes

Checking Environment ... Finished

Checking Gitlab Shell ...

GitLab Shell version? ... 1.3.0 OK (1.3.0) Repo base directory exists? ... yes Repo base directory is a symlink? ... no Repo base owned by git:git? ... yes Repo base access is drwxrws---? ... yes post-receive hook up-to-date? ... yes post-receive hooks in repos are links: ... Verlag Masterwebseite ... repository is empty

Checking Gitlab Shell ... Finished

Checking Sidekiq ...

Running? ... yes

Checking Sidekiq ... Finished

Checking GitLab ...

Database config exists? ... yes Database is SQLite ... no All migrations up? ... yes GitLab config exists? ... yes GitLab config outdated? ... no Log directory writable? ... yes Tmp directory writable? ... yes Init script exists? ... no Try fixing it: Install the init script For more information see: doc/install/installation.md in section "Install Init Script" Please fix the error above and rerun the checks. Init script up-to-date? ... can't check because of previous errors Projects have satellites? ... Verlag Masterwebseite ... can't create, repository is empty Redis version >= 2.0.0? ... yes

Checking GitLab ... Finished