Lots of issues upgrading 4.0 to 4.1

Created by: jponge

I have had a very bad experience doing a migration from 4.0 to 4.1.

I have a Debian set-up that exactly follows your initial installation then upgrade instructions.

1. When doing a gitlab:check, I get a splendid "undefined methodpath_to_repo' for nil:NilClass"`.
2. The configuration file has had section changes / renamings. I found myself with most repos being like in the initial state, having the https URL fine but the ssh one pointing to localhost, etc. I had to restart from scratch because of that. You should mention this in the upgrade notice.
3. Having group/project is a welcome addition... except that it completely breaks the existing repositories because the previous /home/git/repositories layout was flat. I tried moving repositories, editing the gitolite configuration... and ended up 2 hours later simply deleting / recreating repositories.

My report surely sounds harsh. I know what it takes to do opensource and I value the work being put in GitLab, especially as I am using it in a non-profit context.

Nevertheless you would probably benefit from paying more attention to upgrades QA. The upgrade notice from 4.0 to 4.1 seems harmless, but the reality is a huge fiasco. I will certainly be waiting before doing the upgrade to 4.2...