...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::DataBuilder::WikiPage do describe Gitlab::DataBuilder::WikiPage do
set(:project) { create(:project, :repository, :wiki_repo) } let_it_be(:project) { create(:project, :repository, :wiki_repo) }
let(:wiki_page) { create(:wiki_page, wiki: project.wiki) } let(:wiki_page) { create(:wiki_page, wiki: project.wiki) }
let(:user) { create(:user) } let(:user) { create(:user) }
... ...
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::Git::LfsChanges do describe Gitlab::Git::LfsChanges do
set(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
let(:newrev) { '54fcc214b94e78d7a41a9a8fe6d87a5e59500e51' } let(:newrev) { '54fcc214b94e78d7a41a9a8fe6d87a5e59500e51' }
let(:blob_object_id) { '0c304a93cb8430108629bbbcaa27db3343299bc0' } let(:blob_object_id) { '0c304a93cb8430108629bbbcaa27db3343299bc0' }
... ...
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::Git::MergeBase do describe Gitlab::Git::MergeBase do
set(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
let(:repository) { project.repository } let(:repository) { project.repository }
subject(:merge_base) { described_class.new(repository, refs) } subject(:merge_base) { described_class.new(repository, refs) }
... ...
......
...@@ -3,8 +3,7 @@ ...@@ -3,8 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::Git::Push do describe Gitlab::Git::Push do
set(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
let(:oldrev) { project.commit('HEAD~2').id } let(:oldrev) { project.commit('HEAD~2').id }
let(:newrev) { project.commit.id } let(:newrev) { project.commit.id }
let(:ref) { 'refs/heads/some-branch' } let(:ref) { 'refs/heads/some-branch' }
... ...
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe ::Gitlab::GitPostReceive do describe ::Gitlab::GitPostReceive do
set(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
subject { described_class.new(project, "project-#{project.id}", changes.dup, {}) } subject { described_class.new(project, "project-#{project.id}", changes.dup, {}) }
... ...
......
...@@ -3,10 +3,10 @@ ...@@ -3,10 +3,10 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::GitalyClient::OperationService do describe Gitlab::GitalyClient::OperationService do
set(:project) { create(:project, :repository) } let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository) }
let(:repository) { project.repository.raw } let(:repository) { project.repository.raw }
let(:client) { described_class.new(repository) } let(:client) { described_class.new(repository) }
set(:user) { create(:user) }
let(:gitaly_user) { Gitlab::Git::User.from_gitlab(user).to_gitaly } let(:gitaly_user) { Gitlab::Git::User.from_gitlab(user).to_gitaly }
describe '#user_create_branch' do describe '#user_create_branch' do
... ...
......
...@@ -4,7 +4,7 @@ require 'spec_helper' ...@@ -4,7 +4,7 @@ require 'spec_helper'
describe Gitlab::GlobalId do describe Gitlab::GlobalId do
describe '.build' do describe '.build' do
set(:object) { create(:issue) } let_it_be(:object) { create(:issue) }
it 'returns a standard GlobalId if only object is passed' do it 'returns a standard GlobalId if only object is passed' do
expect(described_class.build(object).to_s).to eq(object.to_global_id.to_s) expect(described_class.build(object).to_s).to eq(object.to_global_id.to_s)
... ...
......
...@@ -5,7 +5,7 @@ require 'spec_helper' ...@@ -5,7 +5,7 @@ require 'spec_helper'
describe Gitlab::Graphql::Loaders::BatchLfsOidLoader do describe Gitlab::Graphql::Loaders::BatchLfsOidLoader do
include GraphqlHelpers include GraphqlHelpers
set(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
let(:repository) { project.repository } let(:repository) { project.repository }
let(:blob) { Gitlab::Graphql::Representation::TreeEntry.new(repository.blob_at('master', 'files/lfs/lfs_object.iso'), repository) } let(:blob) { Gitlab::Graphql::Representation::TreeEntry.new(repository.blob_at('master', 'files/lfs/lfs_object.iso'), repository) }
let(:otherblob) { Gitlab::Graphql::Representation::TreeEntry.new(repository.blob_at('master', 'README'), repository) } let(:otherblob) { Gitlab::Graphql::Representation::TreeEntry.new(repository.blob_at('master', 'README'), repository) }
... ...
......
...@@ -186,7 +186,7 @@ describe Gitlab::HashedStorage::Migrator, :redis do ...@@ -186,7 +186,7 @@ describe Gitlab::HashedStorage::Migrator, :redis do
end end
describe 'migration_pending?' do describe 'migration_pending?' do
set(:project) { create(:project, :empty_repo) } let_it_be(:project) { create(:project, :empty_repo) }
it 'returns true when there are MigratorWorker jobs scheduled' do it 'returns true when there are MigratorWorker jobs scheduled' do
Sidekiq::Testing.disable! do Sidekiq::Testing.disable! do
...@@ -210,7 +210,7 @@ describe Gitlab::HashedStorage::Migrator, :redis do ...@@ -210,7 +210,7 @@ describe Gitlab::HashedStorage::Migrator, :redis do
end end
describe 'rollback_pending?' do describe 'rollback_pending?' do
set(:project) { create(:project, :empty_repo) } let_it_be(:project) { create(:project, :empty_repo) }
it 'returns true when there are RollbackerWorker jobs scheduled' do it 'returns true when there are RollbackerWorker jobs scheduled' do
Sidekiq::Testing.disable! do Sidekiq::Testing.disable! do
... ...
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::HookData::IssuableBuilder do describe Gitlab::HookData::IssuableBuilder do
set(:user) { create(:user) } let_it_be(:user) { create(:user) }
# This shared example requires a `builder` and `user` variable # This shared example requires a `builder` and `user` variable
shared_examples 'issuable hook data' do |kind| shared_examples 'issuable hook data' do |kind|
... ...
......
...@@ -3,8 +3,8 @@ ...@@ -3,8 +3,8 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::HookData::IssueBuilder do describe Gitlab::HookData::IssueBuilder do
set(:label) { create(:label) } let_it_be(:label) { create(:label) }
set(:issue) { create(:labeled_issue, labels: [label], project: label.project) } let_it_be(:issue) { create(:labeled_issue, labels: [label], project: label.project) }
let(:builder) { described_class.new(issue) } let(:builder) { described_class.new(issue) }
describe '#build' do describe '#build' do
... ...
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::HookData::MergeRequestBuilder do describe Gitlab::HookData::MergeRequestBuilder do
set(:merge_request) { create(:merge_request) } let_it_be(:merge_request) { create(:merge_request) }
let(:builder) { described_class.new(merge_request) } let(:builder) { described_class.new(merge_request) }
describe '#build' do describe '#build' do
... ...
......
...@@ -3,8 +3,8 @@ ...@@ -3,8 +3,8 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::Import::MergeRequestHelpers, type: :helper do describe Gitlab::Import::MergeRequestHelpers, type: :helper do
set(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
set(:user) { create(:user) } let_it_be(:user) { create(:user) }
describe '.create_merge_request_without_hooks' do describe '.create_merge_request_without_hooks' do
let(:iid) { 42 } let(:iid) { 42 }
... ...
......
...@@ -4,7 +4,7 @@ require 'spec_helper' ...@@ -4,7 +4,7 @@ require 'spec_helper'
describe Gitlab::ImportExport::RepoSaver do describe Gitlab::ImportExport::RepoSaver do
describe 'bundle a project Git repo' do describe 'bundle a project Git repo' do
set(:user) { create(:user) } let_it_be(:user) { create(:user) }
let!(:project) { create(:project, :repository) } let!(:project) { create(:project, :repository) }
let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" } let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" }
let(:shared) { project.import_export_shared } let(:shared) { project.import_export_shared }
... ...
......
...@@ -4,8 +4,8 @@ require 'spec_helper' ...@@ -4,8 +4,8 @@ require 'spec_helper'
describe Gitlab::ImportExport::WikiRepoSaver do describe Gitlab::ImportExport::WikiRepoSaver do
describe 'bundle a wiki Git repo' do describe 'bundle a wiki Git repo' do
set(:user) { create(:user) } let_it_be(:user) { create(:user) }
let!(:project) { create(:project, :wiki_repo) } let_it_be(:project) { create(:project, :wiki_repo) }
let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" } let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" }
let(:shared) { project.import_export_shared } let(:shared) { project.import_export_shared }
let(:wiki_bundler) { described_class.new(project: project, shared: shared) } let(:wiki_bundler) { described_class.new(project: project, shared: shared) }
... ...
......
...@@ -3,13 +3,12 @@ ...@@ -3,13 +3,12 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::JsonCache do describe Gitlab::JsonCache do
let_it_be(:broadcast_message) { create(:broadcast_message) }
let(:backend) { double('backend').as_null_object } let(:backend) { double('backend').as_null_object }
let(:namespace) { 'geo' } let(:namespace) { 'geo' }
let(:key) { 'foo' } let(:key) { 'foo' }
let(:expanded_key) { "#{namespace}:#{key}:#{Gitlab::VERSION}:#{Rails.version}" } let(:expanded_key) { "#{namespace}:#{key}:#{Gitlab::VERSION}:#{Rails.version}" }
set(:broadcast_message) { create(:broadcast_message) }
subject(:cache) { described_class.new(namespace: namespace, backend: backend) } subject(:cache) { described_class.new(namespace: namespace, backend: backend) }
describe '#active?' do describe '#active?' do
... ...
......
...@@ -3,9 +3,9 @@ ...@@ -3,9 +3,9 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::LanguageDetection do describe Gitlab::LanguageDetection do
set(:project) { create(:project, :repository) } let_it_be(:project) { create(:project, :repository) }
set(:ruby) { create(:programming_language, name: 'Ruby') } let_it_be(:ruby) { create(:programming_language, name: 'Ruby') }
set(:haskell) { create(:programming_language, name: 'Haskell') } let_it_be(:haskell) { create(:programming_language, name: 'Haskell') }
let(:repository) { project.repository } let(:repository) { project.repository }
let(:detection) do let(:detection) do
[{ value: 66.63, label: "Ruby", color: "#701516", highlight: "#701516" }, [{ value: 66.63, label: "Ruby", color: "#701516", highlight: "#701516" },
... ...
......
...@@ -5,9 +5,9 @@ require 'spec_helper' ...@@ -5,9 +5,9 @@ require 'spec_helper'
describe Gitlab::Metrics::Dashboard::Finder, :use_clean_rails_memory_store_caching do describe Gitlab::Metrics::Dashboard::Finder, :use_clean_rails_memory_store_caching do
include MetricsDashboardHelpers include MetricsDashboardHelpers
set(:project) { create(:project) } let_it_be(:project) { create(:project) }
set(:user) { create(:user) } let_it_be(:user) { create(:user) }
set(:environment) { create(:environment, project: project) } let_it_be(:environment) { create(:environment, project: project) }
before do before do
project.add_maintainer(user) project.add_maintainer(user)
... ...
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::PhabricatorImport::Cache::Map, :clean_gitlab_redis_cache do describe Gitlab::PhabricatorImport::Cache::Map, :clean_gitlab_redis_cache do
set(:project) { create(:project) } let_it_be(:project) { create(:project) }
let(:redis) { Gitlab::Redis::Cache } let(:redis) { Gitlab::Redis::Cache }
subject(:map) { described_class.new(project) } subject(:map) { described_class.new(project) }
... ...
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
require 'spec_helper' require 'spec_helper'
describe Gitlab::PhabricatorImport::Issues::TaskImporter do describe Gitlab::PhabricatorImport::Issues::TaskImporter do
set(:project) { create(:project) } let_it_be(:project) { create(:project) }
let(:task) do let(:task) do
Gitlab::PhabricatorImport::Representation::Task.new( Gitlab::PhabricatorImport::Representation::Task.new(
{ {
... ...
......