File changed. Contains only whitespace changes. Show whitespace changes.
...@@ -45,9 +45,9 @@ page, with these behaviours: ...@@ -45,9 +45,9 @@ page, with these behaviours:
1. It will not pick people whose [GitLab status](../user/profile/index.md#current-status) 1. It will not pick people whose [GitLab status](../user/profile/index.md#current-status)
contains the string 'OOO'. contains the string 'OOO'.
2. [Trainee maintainers](https://about.gitlab.com/handbook/engineering/workflow/code-review/#trainee-maintainer) 1. [Trainee maintainers](https://about.gitlab.com/handbook/engineering/workflow/code-review/#trainee-maintainer)
are three times as likely to be picked as other reviewers. are three times as likely to be picked as other reviewers.
3. It always picks the same reviewers and maintainers for the same 1. It always picks the same reviewers and maintainers for the same
branch name (unless their OOO status changes, as in point 1). It branch name (unless their OOO status changes, as in point 1). It
removes leading `ce-` and `ee-`, and trailing `-ce` and `-ee`, so removes leading `ce-` and `ee-`, and trailing `-ce` and `-ee`, so
that it can be stable for backport branches. that it can be stable for backport branches.
... ...
......
File changed. Contains only whitespace changes. Show whitespace changes.
File changed. Contains only whitespace changes. Show whitespace changes.
...@@ -141,7 +141,7 @@ All reviewers can help ensure accuracy, clarity, completeness, and adherence to ...@@ -141,7 +141,7 @@ All reviewers can help ensure accuracy, clarity, completeness, and adherence to
- After merging, documentation changes are reviewed by: - After merging, documentation changes are reviewed by:
1. The technical writer -- **if** their review was not performed prior to the merge. 1. The technical writer -- **if** their review was not performed prior to the merge.
2. Optionally: by the PM (for accuracy and to ensure it's consistent with the vision for how the product will be used). 1. Optionally: by the PM (for accuracy and to ensure it's consistent with the vision for how the product will be used).
Any party can raise the item to the PM for review at any point: the dev, the technical writer, or the PM, who can request/plan a review at the outset. Any party can raise the item to the PM for review at any point: the dev, the technical writer, or the PM, who can request/plan a review at the outset.
### Technical Writer role ### Technical Writer role
... ...
......
File changed. Contains only whitespace changes. Show whitespace changes.
File changed. Contains only whitespace changes. Show whitespace changes.
File changed. Contains only whitespace changes. Show whitespace changes.
...@@ -80,9 +80,9 @@ In conclusion, we need three things for effective object deduplication ...@@ -80,9 +80,9 @@ In conclusion, we need three things for effective object deduplication
across a collection of GitLab project repositories at the Git level: across a collection of GitLab project repositories at the Git level:
1. A pool repository must exist. 1. A pool repository must exist.
2. The participating project repositories must be linked to the pool 1. The participating project repositories must be linked to the pool
repository via their respective `objects/info/alternates` files. repository via their respective `objects/info/alternates` files.
3. The pool repository must contain Git object data common to the 1. The pool repository must contain Git object data common to the
participating project repositories. participating project repositories.
### Deduplication factor ### Deduplication factor
... ...
......
...@@ -71,7 +71,6 @@ class myClass { ...@@ -71,7 +71,6 @@ class myClass {
} }
const instance = new myClass(); const instance = new myClass();
instance.makeRequest(); instance.makeRequest();
``` ```
## Avoid classes to handle DOM events ## Avoid classes to handle DOM events
... ...
......
...@@ -137,8 +137,8 @@ secure note named **gitlab-{ce,ee} Review App's root password**. ...@@ -137,8 +137,8 @@ secure note named **gitlab-{ce,ee} Review App's root password**.
### Run a Rails console ### Run a Rails console
1. [Filter Workloads by your Review App slug](https://console.cloud.google.com/kubernetes/workload?project=gitlab-review-apps) 1. [Filter Workloads by your Review App slug](https://console.cloud.google.com/kubernetes/workload?project=gitlab-review-apps),
, e.g. `review-qa-raise-e-12chm0`. e.g. `review-qa-raise-e-12chm0`.
1. Find and open the `task-runner` Deployment, e.g. `review-qa-raise-e-12chm0-task-runner`. 1. Find and open the `task-runner` Deployment, e.g. `review-qa-raise-e-12chm0-task-runner`.
1. Click on the Pod in the "Managed pods" section, e.g. `review-qa-raise-e-12chm0-task-runner-d5455cc8-2lsvz`. 1. Click on the Pod in the "Managed pods" section, e.g. `review-qa-raise-e-12chm0-task-runner-d5455cc8-2lsvz`.
1. Click on the `KUBECTL` dropdown, then `Exec` -> `task-runner`. 1. Click on the `KUBECTL` dropdown, then `Exec` -> `task-runner`.
... ...
......
File changed. Contains only whitespace changes. Show whitespace changes.
...@@ -11,6 +11,7 @@ comments: false ...@@ -11,6 +11,7 @@ comments: false
```bash ```bash
git init git init
``` ```
- Copy an existing project by cloning the repository through: - Copy an existing project by cloning the repository through:
```bash ```bash
... ...
......