| ... | @@ -8,28 +8,42 @@ describe CommitPolicy do |
... | @@ -8,28 +8,42 @@ describe CommitPolicy do |
|
|
let(:commit) { project.repository.head_commit }
|
|
let(:commit) { project.repository.head_commit }
|
|
|
let(:policy) { described_class.new(user, commit) }
|
|
let(:policy) { described_class.new(user, commit) }
|
|
|
|
|
|
|
|
|
shared_examples 'can read commit and create a note' do
|
|
|
|
it 'can read commit' do
|
|
|
|
expect(policy).to be_allowed(:read_commit)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can create a note' do
|
|
|
|
expect(policy).to be_allowed(:create_note)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'cannot read commit nor create a note' do
|
|
|
|
it 'can not read commit' do
|
|
|
|
expect(policy).to be_disallowed(:read_commit)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can not create a note' do
|
|
|
|
expect(policy).to be_disallowed(:create_note)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
context 'when project is public' do
|
|
context 'when project is public' do
|
|
|
let(:project) { create(:project, :public, :repository) }
|
|
let(:project) { create(:project, :public, :repository) }
|
|
|
|
|
|
|
|
it 'can read commit and create a note' do
|
|
it_behaves_like 'can read commit and create a note'
|
|
|
expect(policy).to be_allowed(:read_commit)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when repository access level is private' do
|
|
context 'when repository access level is private' do
|
|
|
let(:project) { create(:project, :public, :repository, :repository_private) }
|
|
let(:project) { create(:project, :public, :repository, :repository_private) }
|
|
|
|
|
|
|
|
it 'can not read commit and create a note' do
|
|
it_behaves_like 'cannot read commit nor create a note'
|
|
|
expect(policy).to be_disallowed(:read_commit)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when the user is a project member' do
|
|
context 'when the user is a project member' do
|
|
|
before do
|
|
before do
|
|
|
project.add_developer(user)
|
|
project.add_developer(user)
|
|
|
end
|
|
end
|
|
|
|
|
|
|
|
it 'can read commit and create a note' do
|
|
it_behaves_like 'can read commit and create a note'
|
|
|
expect(policy).to be_allowed(:read_commit)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
end
|
|
|
end
|
|
end
|
|
|
end
|
|
end
|
| ... | @@ -37,9 +51,7 @@ describe CommitPolicy do |
... | @@ -37,9 +51,7 @@ describe CommitPolicy do |
|
|
context 'when project is private' do
|
|
context 'when project is private' do
|
|
|
let(:project) { create(:project, :private, :repository) }
|
|
let(:project) { create(:project, :private, :repository) }
|
|
|
|
|
|
|
|
it 'can not read commit and create a note' do
|
|
it_behaves_like 'cannot read commit nor create a note'
|
|
|
expect(policy).to be_disallowed(:read_commit)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when the user is a project member' do
|
|
context 'when the user is a project member' do
|
|
|
before do
|
|
before do
|
| ... | @@ -50,6 +62,18 @@ describe CommitPolicy do |
... | @@ -50,6 +62,18 @@ describe CommitPolicy do |
|
|
expect(policy).to be_allowed(:read_commit)
|
|
expect(policy).to be_allowed(:read_commit)
|
|
|
end
|
|
end
|
|
|
end
|
|
end
|
|
|
|
|
|
|
|
context 'when the user is a guest' do
|
|
|
|
before do
|
|
|
|
project.add_guest(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'cannot read commit nor create a note'
|
|
|
|
|
|
|
|
it 'cannot download code' do
|
|
|
|
expect(policy).to be_disallowed(:download_code)
|
|
|
|
end
|
|
|
|
end
|
|
|
end
|
|
end
|
|
|
end
|
|
end
|
|
|
end |
|
end |